fix(kollider): routes

[fczuardi]

Describe the changes you have made in this PR

Kollider wallet variants (buttons signup and login) were not working as expected.

Link this PR to an issue [optional]

Fixes #2355

Type of change

(Remove other not matching type)

• fix: Bug fix (non-breaking change which fixes an issue)
• feat: New feature (non-breaking change which adds functionality)
• feat!: Breaking change (fix or feature that would cause existing functionality to not work as expected)
• docs: Documentation update

Screenshots of the changes [optional]

Add screenshots to make your changes easier to understand. You can also add a video here.

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

• My code follows the style guidelines of this project and performed a self-review of my own code
• New and existing tests pass locally with my changes
• I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

[github-actions]

🚀 Thanks for the pull request!

Here are the current build files for testing:

• chrome.zip.zip
• firefox.xpi.zip
• opera.crx.zip

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

---

This build is brought to you by: channel.ninja (who recently dropped 1000 sats):

---

Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

[im-adithya]

Thanks for the PR, but this change makes /kollider route empty

Also I am not able to reproduce the issue mentioned here: #2250 (comment)

cc @reneaaron

[fczuardi]

Thanks for the PR, but this change makes /kollider route empty

Also I am not able to reproduce the issue mentioned here: #2250 (comment)

cc @reneaaron

Here is a video displaying the steps to reproduce and the clicks:

Kollider-routes.webm

Basically, it is :

• clone the repo
• yarn
• yarn dev:chrome
• load unpacked extension

I was able to reproduce it on the master branch for both Brave, Chrome and Firefox. With node versions v16.18.0 and v18.15.0.

[fczuardi]

makes /kollider route empty

nope, since there is an "index" child

[lujakob]

@im-adithya could you please explain what the cause of the bug was and what the reasoning behind the solution is. These changes will cause merge-conflicts with #2272 that I'm working on.

[im-adithya]

My commit basically adds recursive looping for those routes instead of the hardcoded mapping (which assumes one child at max) and also expects the parent to have an element property which has now been changed after @fczuardi's commit to have the component as the index child

[reneaaron]

tACK