Bug/changed rendering condition to get "no transactions" message only when needed #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request Pull request alert summary
|
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep earning sats! |
mviswanathsai
changed the title
|
Thank you for your pull request @mviswanathsai! It should be !isLoadingTransactions && !transactions?.lengthinstead of !hasTransactions && !transactions?.lengthbecause |
im-adithya
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
The message "no transactions on snort yet" was shown while loading was also happening. I have changed the conditional rendering condition to prevent this.
Link this PR to an issue [optional]
Fixes #2219
Type of change
fix: Bug fix (non-breaking change which fixes an issue)How has this been tested?
I tested with different boolean values manually for different scenarios to make sure that the conditional render for the message will only happen when the favored condition happens. Had to do this since I could not access snort on testnet to make any transactions.
Checklist