-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lnurl-auth onboarding #2754
Conversation
|
@pavanjoshi914 when I disable login from the allowance, refresh the page and login I get an error: |
It also happens when I am using an LND connector, when I disconnect the site (completely remove the allowance), refresh, and then try to login again (on https://webln.twentyuno.net/login) |
…-extension into lnurl-auth-onboarding
…ghtning-browser-extension into lnurl-auth-onboarding
Fixed in new commits that happened because I was just calling the authPrompt, and not returning the response given by the authPrompt call. we need to return response back to content script else it will get a response as undefined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
…ghtning-browser-extension into lnurl-auth-onboarding
instead of depending on connector type, now we depend on user wish to use mnemonic or not. the behaviour is:: for other connectors
|
lnurl auth onboarding shifted in enable screen
Link this PR to an issue [optional]
Fixes #2713
Type of change
(Remove other not matching type)
feat
: New feature (non-breaking change which adds functionality)Screenshots of the changes [optional]
Add screenshots to make your changes easier to understand. You can also add a video here.
2023-09-15.10-41-24.mp4
Checklist