Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: responsive header, navigation and headings and avatars #2959

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

pavanjoshi914
Copy link
Contributor

Describe the changes you have made in this PR

fix headers navigation icons

Link this PR to an issue [optional]

Fixes #ISSUE-NUMBER

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

before:
image
after:

image

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

@pavanjoshi914
Copy link
Contributor Author

@rolznz @reneaaron here i am thinking what we do about the heading. it's something like pavanjoshi2050@gmail.com/Account settings this is quite big. and breaks responsiveness on smaller screen. is there specific reason to include account name as well in headings?

@pavanjoshi914 pavanjoshi914 requested a review from rolznz December 26, 2023 05:13
@pavanjoshi914 pavanjoshi914 changed the title feat: add margins around navigation icons feat: responsive header, navigation and headings and avatars Dec 27, 2023
@pavanjoshi914
Copy link
Contributor Author

@rolznz @reneaaron here i am thinking what we do about the heading. it's something like pavanjoshi2050@gmail.com/Account settings this is quite big. and breaks responsiveness on smaller screen. is there specific reason to include account name as well in headings?

new changes regarding the same:::

2023-12-27.14-34-15.mp4

src/app/components/Avatar/index.tsx Outdated Show resolved Hide resolved
src/app/components/Avatar/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@reneaaron reneaaron merged commit f027a1d into master Jan 31, 2024
6 of 7 checks passed
@reneaaron reneaaron deleted the fix/header branch January 31, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants