Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NFT profile for twitter #2968

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

agustinkassis
Copy link
Contributor

Describe the changes you have made in this PR

Added support for NFT profiles on Twitter.

Type of change

(Remove other not matching type)

  • fix: Bug fix, Blue icon was not working when Twitter user was using an NFT as profile picture

How has this been tested?

Running the extension locally. Its a simple change.

Checklist

  • Self-review of changed code
  • Manual testing

@agustinkassis
Copy link
Contributor Author

Hey there, can you please merge the following PR? Its a simple line of code that fixes a bug.

@pavanjoshi914
Copy link
Contributor

@agustinkassis thanks for your contribution!

if profile is set as nft, url endpoint is /nft and not /photo so we need to check for both
image

LGTM!

Copy link
Contributor

@pavanjoshi914 pavanjoshi914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@pavanjoshi914 pavanjoshi914 merged commit 23cac3c into getAlby:master Jan 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants