Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use new nwc client from sdk #2987

Merged
merged 8 commits into from
Jul 15, 2024
Merged

feat: use new nwc client from sdk #2987

merged 8 commits into from
Jul 15, 2024

Conversation

im-adithya
Copy link
Member

@im-adithya im-adithya commented Jan 5, 2024 •
edited
Loading

Describe the changes you have made in this PR

Used the new NWCClient instead of using the outdated webln.NostrWebLNProvider, that way we get Nip47Response types from the methods instead of Webln

How has this been tested?

Using Jest

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides

@im-adithya im-adithya requested review from bumi and rolznz January 5, 2024 13:46
@im-adithya im-adithya marked this pull request as draft January 5, 2024 13:51
@im-adithya im-adithya force-pushed the task-nwc-makeinvoice branch from 98e2330 to fe51f19 Compare July 2, 2024 09:38
@im-adithya im-adithya changed the title chore(makeInvoice): use paymentHash from result feat: use new nwc client from sdk Jul 2, 2024
@im-adithya im-adithya marked this pull request as ready for review July 2, 2024 10:10
@im-adithya im-adithya requested a review from pavanjoshi914 July 2, 2024 10:23
@im-adithya im-adithya marked this pull request as draft July 4, 2024 13:06
@im-adithya im-adithya marked this pull request as ready for review July 8, 2024 08:52
@im-adithya im-adithya force-pushed the task-nwc-makeinvoice branch from 02f7740 to 6f9b5de Compare July 8, 2024 08:53
@pavanjoshi914
Copy link
Contributor

utAck

@pavanjoshi914 pavanjoshi914 merged commit b43119d into master Jul 15, 2024
6 checks passed
@pavanjoshi914 pavanjoshi914 deleted the task-nwc-makeinvoice branch July 15, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolznz rolznz rolznz left review comments

@bumi bumi bumi left review comments

@pavanjoshi914 pavanjoshi914 Awaiting requested review from pavanjoshi914

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@im-adithya @pavanjoshi914 @bumi @rolznz