fix lnurl channel #3046
Merged
fix lnurl channel #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show proper error messages
|
sry i just quickly coded it. need to improve the pr a bit. thanks for the review addressing it |
reneaaron
approved these changes
Feb 22, 2024
|
will merge this. i think functionality is complete now. if there are further improvements we need to do. i can do a follow up pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show proper error messages
Describe the changes you have made in this PR
fix lnurl callback
proper error messages while doing requests
Type of change
(Remove other not matching type)
fix: Bug fix (non-breaking change which fixes an issue)Checklist