Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styling and other issues on Apple Devices #3065

Merged
merged 13 commits into from
Mar 18, 2024
Merged

fix: styling and other issues on Apple Devices #3065

merged 13 commits into from
Mar 18, 2024

Conversation

im-adithya
Copy link
Member

@im-adithya im-adithya commented Mar 5, 2024

Describe the changes you have made in this PR

Common changes among iOS, iPad and Mac (Safari only)

Fixes blank screen issue on start page
Prevents Start Page(s) from being removed resulting in closing of Safari while locking the extension

iOS

Replaces w-96 with w-full

iPad

Removes max-w-full as that is disturbing the popup size

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

How has this been tested?

Manually

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

@im-adithya im-adithya requested a review from pavanjoshi914 March 5, 2024 14:40
@pavanjoshi914
Copy link
Contributor

it breaks for firefox and firefox for android

is there any way to inspect popup on ios. is that popup somehow scrollable? we need to keep fix width for the popup and not adaptive width. we will never know which browser will break this changes
it also depends on version. for eg. older browser version newer browser version. the rendering is different.
maybe we shall avoid touching core template and see if we can fix the screen to adapt to ios and other browsers

image

@reneaaron reneaaron marked this pull request as draft March 8, 2024 08:53
@im-adithya im-adithya marked this pull request as ready for review March 12, 2024 10:24
@im-adithya im-adithya changed the title fix: use min width instead fo fixed width fix: use useragent to adjust width on Safari iOS Mar 12, 2024
@reneaaron reneaaron added the next-release To be included in the next release label Mar 13, 2024
@im-adithya im-adithya changed the title fix: use useragent to adjust width on Safari iOS fix: styling and other issues on Apple Devices Mar 14, 2024
src/app/router/Popup/index.tsx Outdated Show resolved Hide resolved
src/app/router/Popup/index.tsx Show resolved Hide resolved
src/app/screens/Home/index.tsx Show resolved Hide resolved
src/extension/background-script/state.ts Show resolved Hide resolved
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@reneaaron reneaaron enabled auto-merge (squash) March 18, 2024 12:05
@reneaaron reneaaron merged commit 9e76550 into master Mar 18, 2024
6 checks passed
@reneaaron reneaaron deleted the task-popup branch March 18, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release To be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants