Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deny permissions #3112

Merged
merged 8 commits into from
Apr 9, 2024
Merged

feat: deny permissions #3112

merged 8 commits into from
Apr 9, 2024

Conversation

pavanjoshi914
Copy link
Contributor

@pavanjoshi914 pavanjoshi914 commented Mar 27, 2024 •
edited
Loading

Describe the changes you have made in this PR

deny permissoins functionality

Type of change

(Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

@pavanjoshi914 pavanjoshi914 marked this pull request as ready for review April 1, 2024 09:22
@pavanjoshi914 pavanjoshi914 requested a review from reneaaron April 1, 2024 10:26
reneaaron
reneaaron requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! 💯

cACK, will need to do some more testing

  • We might want to add some unit tests for the new block feature?

src/app/components/SitePreferences/index.tsx Outdated Show resolved Hide resolved
src/app/screens/Nostr/ConfirmSignMessage.tsx Show resolved Hide resolved
@pavanjoshi914 pavanjoshi914 merged commit 3ddf632 into master Apr 9, 2024
7 checks passed
@pavanjoshi914 pavanjoshi914 deleted the deny-permissions branch April 9, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackingsaunter stackingsaunter stackingsaunter left review comments

@reneaaron reneaaron reneaaron requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavanjoshi914 @stackingsaunter @reneaaron