Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no limit warning #3134

Merged
merged 14 commits into from
May 14, 2024
Merged

feat: no limit warning #3134

merged 14 commits into from
May 14, 2024

Conversation

pavanjoshi914
Copy link
Contributor

Describe the changes you have made in this PR

add warning for custodial users having no limit

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

@pavanjoshi914 pavanjoshi914 marked this pull request as draft April 25, 2024 15:06
@pavanjoshi914 pavanjoshi914 marked this pull request as ready for review April 26, 2024 08:46
Comment on lines 151 to 153
const info = await this._request((client) =>
client.accountInformation({})
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the new endpoint instead of this one? it should contain the same information and the additional account limit info.

so we don't need to do a second request.

src/extension/background-script/connectors/alby.ts Outdated Show resolved Hide resolved
@reneaaron reneaaron added the next-release To be included in the next release label Apr 29, 2024
@pavanjoshi914 pavanjoshi914 requested a review from reneaaron May 1, 2024 06:23
@pavanjoshi914
Copy link
Contributor Author

tAck

@pavanjoshi914 pavanjoshi914 merged commit 8435e0a into master May 14, 2024
7 checks passed
@pavanjoshi914 pavanjoshi914 deleted the no-limit-warning branch May 14, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release To be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants