feat: unchain unlock call from enable screen #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
May 13, 2024
reneaaron
reviewed
May 16, 2024
pavanjoshi914
changed the title
|
Tested and worked like intended. 👍 There is still a bug when you manually lock the extension after you enabled it on this website before, which leads to an erroneous state in the extension (you need to manually reload it afterwards in order to use it again). This bug was already in there for years though, so I don't think we need to fix that in this PR. tACK |
reneaaron
approved these changes
May 21, 2024
bumi
reviewed
May 21, 2024
| if ( | ||
| isUnlocked && |
There was a problem hiding this comment.
don't we still need the unlock check? because if your new check fails for whatever reason then it's not unlocked and this action should not run.
…ghtning-browser-extension into unchain-unlock-enable
return custom error message object when error is not instance of Error
bumi
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
unchain unlock screen from enable screen
Link this PR to an issue [optional]
fixes triggering of enable screen for nostr when extension is locked, even if the provider was persisted before.
this also reduces the side effect of user needed to set permission again because of retriggering of enable screens
Type of change
(Remove other not matching type)
feat: New feature (non-breaking change which adds functionality)Checklist