Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: revamp-nostr-settings #3147

Merged
merged 13 commits into from
May 23, 2024
Merged

feat: revamp-nostr-settings #3147

merged 13 commits into from
May 23, 2024

Conversation

pavanjoshi914
Copy link
Contributor

Describe the changes you have made in this PR

new ui for nostr settings page

Link this PR to an issue [optional]

(Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

stackingsaunter
stackingsaunter requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@stackingsaunter stackingsaunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we display the imported badge along private key input instead of public key?

image

reneaaron
reneaaron reviewed May 21, 2024
View reviewed changes
src/extension/background-script/connectors/alby.ts Outdated
try {
const node_required = await this._isNodeRequired();
Copy link
Contributor

@reneaaron reneaaron May 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now for every user there is an additional request for this field 🤔

@reneaaron
Copy link
Contributor

Looks great so far, fixed some minor things directly.

  1. Please have a look at the mobile styles for this new page:
    image

  2. 2 API calls every time you open the extension is a bit much, could we potentially merge them into one at least? (the internal API should return all of the information that the public API returns, anyway)

Otherwise this is a great change! 💯

tACK

@reneaaron reneaaron added the next-release To be included in the next release label May 21, 2024
@pavanjoshi914
Copy link
Contributor Author

  1. merged api call into single. we only make internal api call now
  2. updated types accordingly
  3. added cache back
  4. fixed responsiveness

@pavanjoshi914
Copy link
Contributor Author

tAck

@pavanjoshi914 pavanjoshi914 merged commit d258cbb into master May 23, 2024
7 checks passed
@pavanjoshi914 pavanjoshi914 deleted the revamp-nostr-settings branch May 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneaaron reneaaron reneaaron left review comments

@stackingsaunter stackingsaunter stackingsaunter requested changes

Assignees
No one assigned
Labels
next-release To be included in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavanjoshi914 @reneaaron @stackingsaunter