Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrollbar on extension popup #3199

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

pavanjoshi914
Copy link
Contributor

fix scrollbar and shift of view in popup for latest chromium browsers

before:
image

now:
image

@reneaaron
Copy link
Contributor

This change effectively removes the scrollbar completely for chromium browsers? I'm not sure we want that as there is no indication anymore that you can scroll the view at all.

According to the docs auto should be the default anyway 🤔

@bitcoinuser
Copy link
Contributor

This change effectively removes the scrollbar completely for chromium browsers? I'm not sure we want that as there is no indication anymore that you can scroll the view at all.

According to the docs auto should be the default anyway 🤔

I prefer no scrollbar.

@pavanjoshi914
Copy link
Contributor Author

i tested it on chrome + brave latest version. it removes scrollbar only from popup where we don't want any kind of scrollbar right? it won't effect prompt and options view

@reneaaron
Copy link
Contributor

i tested it on chrome + brave latest version. it removes scrollbar only from popup where we don't want any kind of scrollbar right? it won't effect prompt and options view

Yes, but also in the popup there is no indication that you can actually scroll. On Firefox there still is one, and I wonder if it's a good practice to just hide the scrollbar completely.

image

@pavanjoshi914
Copy link
Contributor Author

i would prefer not having scrollbar in the context of the popups. by default we use no-scrollbar for popup's but it doesn't have any effect on latest browser. so I added additional rule to make it work. let me know if we shall go with this pr

@pavanjoshi914 pavanjoshi914 merged commit 51124ca into master Jul 18, 2024
6 checks passed
@pavanjoshi914 pavanjoshi914 deleted the fix-scrollbar-popup branch July 18, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants