React Router v6 + Auth Flow #384
Conversation
dylancom
commented
Nov 15, 2021
•
dylancom
commented
- Upgraded from v5. (Many API changes)
- Added auth-flow (using context). Protected screens will not be viewable anymore when locked.
|
No matching routes for adding a new account from the options page: |
|
Fixed |
src/app/context/AuthContext.tsx
Outdated
|
|
||
| const unlock = (password: string, callback: VoidFunction) => { | ||
| return utils.call("unlock", { password }).then(() => { | ||
| setUser("alby"); |
There was a problem hiding this comment.
why do we call setUser with "alby"? - can we document that somewhere?
There was a problem hiding this comment.
I am wondering if calling it user is the best here... we will always only have one user, but multiple accounts. maybe we can "authenticate" towards one account? and store here which account is currently used?
There was a problem hiding this comment.
Currently "alby" is just a placeholder, could be "user" aswel. We only check for the presence of a value inside the app. But we could store here also which account is currently used.
There was a problem hiding this comment.
if we call it account or something like currentAccount then we would not introduce another terminology/entity.
…lightning-browser-extension into upgrade/react-router-v6
…lightning-browser-extension into upgrade/react-router-v6
|
@dylancom can you rebase and then merge? |
Co-authored-by: Michael Bumann <hello@michaelbumann.com>
Co-authored-by: Michael Bumann <hello@michaelbumann.com>
Co-authored-by: Michael Bumann <hello@michaelbumann.com>
