-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typed connectors #433
Typed connectors #433
Conversation
async request( | ||
method: string, | ||
path: string, | ||
apiKey: string | undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this one really be undefined?
data: { | ||
preimage: string; | ||
paymentHash: string; | ||
route: { total_amt: number; total_fees: number }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it is a good time to not have this nested in the route
option?
originally I tried to follow lnd's response as much as possible, but I am not sure if that makes sense for us
Solves #283