-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unlock screen Alby logo to proper artwork #513
Conversation
Hmm I'm not sure if we need to emphasize on the tipping feature here? |
I think @johnsBeharry button was more a suggestion for websites that can use it to indicate tips can be sent by Alby. the main problem with the current Alby was that is was an old one with different eyes. |
Ohh ok sorry I misunderstood the convo in Slack, I thought we also wanted to use this logo for the unlock screen. But if @johnsBeharry can send me a different piece of artwork then I can use that one for sure. |
@dylancom I think this one does not work that well with light/dark mode and we might need to show two different ones. or simply only use the Alby (without the "Alby" text) - even though it might be good that people see the name more often :) |
do we still want to update this or is this issue closed? |
what do you suggest for the dark mode? |
I am not sure how we would dynamically change the img src when dark mode is active right now, but I'm sure its possible... for now I think just having Alby without the text would be a good option. I can put in a new PR for that if we agree on it? |
oh... wait we use an SVG.. can't we then just use CSS to change the color of the elements in the SVG? |
Oh right that's true, let me give it a try and I'll let you know if it works. |
here is what I thought in a codepen: https://codepen.io/bumibumi/pen/RwLvVGp |
See #523, if we directly render an svg we can set a text color on a parent and let the SVG inherit it. (using currentColor). |
nice, did not know about currentColor! looks good |
Very cool, nice work @dylancom! |
@secondl1ght thanks! |
@bumi noticed that the Alby logo on the unlock screen had an outdated artwork. I have updated it to the new design that johns created. I think it looks really great! Some feedback would be good on sizing though, currently it is fairly big, I think it looks good but I can make it smaller if people think it is too big.
Screenshot: