Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unlock screen Alby logo to proper artwork #513

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

secondl1ght
Copy link
Contributor

@secondl1ght secondl1ght commented Jan 8, 2022

@bumi noticed that the Alby logo on the unlock screen had an outdated artwork. I have updated it to the new design that johns created. I think it looks really great! Some feedback would be good on sizing though, currently it is fairly big, I think it looks good but I can make it smaller if people think it is too big.

Screenshot:
image

@dylancom
Copy link
Contributor

dylancom commented Jan 9, 2022

Hmm I'm not sure if we need to emphasize on the tipping feature here?

@bumi
Copy link
Collaborator

bumi commented Jan 9, 2022

I think @johnsBeharry button was more a suggestion for websites that can use it to indicate tips can be sent by Alby.

the main problem with the current Alby was that is was an old one with different eyes.
@johnsBeharry do you have some idea for some logo/artwork here?

@secondl1ght
Copy link
Contributor Author

Ohh ok sorry I misunderstood the convo in Slack, I thought we also wanted to use this logo for the unlock screen. But if @johnsBeharry can send me a different piece of artwork then I can use that one for sure.

@dylancom dylancom merged commit 53406be into getAlby:master Jan 14, 2022
@bumi
Copy link
Collaborator

bumi commented Jan 14, 2022

@dylancom I think this one does not work that well with light/dark mode and we might need to show two different ones.

or simply only use the Alby (without the "Alby" text) - even though it might be good that people see the name more often :)

@secondl1ght
Copy link
Contributor Author

do we still want to update this or is this issue closed?

@bumi
Copy link
Collaborator

bumi commented Jan 14, 2022

what do you suggest for the dark mode?

@secondl1ght
Copy link
Contributor Author

I am not sure how we would dynamically change the img src when dark mode is active right now, but I'm sure its possible... for now I think just having Alby without the text would be a good option. I can put in a new PR for that if we agree on it?

@bumi
Copy link
Collaborator

bumi commented Jan 15, 2022

oh... wait we use an SVG.. can't we then just use CSS to change the color of the elements in the SVG?

@secondl1ght
Copy link
Contributor Author

Oh right that's true, let me give it a try and I'll let you know if it works.

@secondl1ght
Copy link
Contributor Author

So it looks like you can change the background color of the SVG based on dark mode but not the text of the 'Alby' letters. I gave it a try to see what everything thinks:

Before:
image

After:
image

I think the background makes it a little bit more legible. What do you guys think?

@bumi
Copy link
Collaborator

bumi commented Jan 15, 2022

here is what I thought in a codepen: https://codepen.io/bumibumi/pen/RwLvVGp

@dylancom
Copy link
Contributor

See #523, if we directly render an svg we can set a text color on a parent and let the SVG inherit it. (using currentColor).

@bumi
Copy link
Collaborator

bumi commented Jan 15, 2022

nice, did not know about currentColor! looks good

@secondl1ght
Copy link
Contributor Author

Very cool, nice work @dylancom!

@dylancom
Copy link
Contributor

@secondl1ght thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants