fix: Set YARN_CHECKSUM_BEHAVIOR=update when 'yarn up' is called #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symwell
changed the title
symwell
force-pushed
the
sw/remote_archive_doesnt_match_the_expected_checksum__version2
branch
from
47d53e8 to
3586bb9
Compare
symwell
force-pushed
the
sw/remote_archive_doesnt_match_the_expected_checksum__version2
branch
from
3586bb9 to
51cf081
Compare
symwell
force-pushed
the
sw/remote_archive_doesnt_match_the_expected_checksum__version2
branch
from
51cf081 to
577526c
Compare
dustinbyrne
reviewed
Dec 20, 2022
| @@ -23,6 +23,9 @@ export type SpawnOptions = { | |||
| // Command line args given to `node` or the `bin` script specified | |||
| args?: string[]; | |||
|
|
|||
| // Additional environment variables given to `node` or the `bin` script specified | |||
| env?: Record<string, string>; | |||
|
|
|||
| // If specified, write log messages to the given output channel | |||
There was a problem hiding this comment.
This should already be included via childProcess.SpawnOptionsWithoutStdio
interface ProcessEnvOptions {
uid?: number | undefined;
gid?: number | undefined;
cwd?: string | undefined;
env?: NodeJS.ProcessEnv | undefined;
}
dustinbyrne
approved these changes
Dec 20, 2022
|
🎉 This PR is included in version 0.57.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix the following type of error we often see in the logs
When an archive checksum in
yarn.lockis incorrect andYARN_CHECKSUM_BEHAVIOR=update yarnis called instead of onlyyarn, the archive is fetched again and doesn't produce this error.Addresses #547 but it's uncertain if it will fix it. It's uncertain if archive checksums were calculated incorrectly due to bugs in yarn when the archive was created or if there's some other error, like something weird going on with the network.
--
To test this I created a vsix file and installed it with logging in
nodeDependencyProcess.ts:spawnthat showedYARN_CHECKSUM_BEHAVIORwas set