Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 8 support #200

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Add .NET 8 support #200

merged 3 commits into from
Jan 30, 2024

Conversation

mpekurny
Copy link
Contributor

Adding .NET 8 support for builds and updated dependencies to latest versions.

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>
… matrix for different dotnet versions in the build.yml

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>
@mpekurny
Copy link
Contributor Author

@sriv @zabil
I am not really sure why the tests are failing. It looks like it's failing on talking to the html reporting plugin which should not have been impacted from my changes to the dotnet plugin? Also the windows tests were stopped while downloading files, so is there some sort of storage cap we are running into where things are failing because of disk space?

@sriv
Copy link
Member

sriv commented Jan 24, 2024

It does look a bit strange to start with. I will investigate this

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>
@mpekurny
Copy link
Contributor Author

@sriv @zabil
There does seem to be some sort of cap (memory, cpu, storage) that the builds were running into. I edited the build.yml file to limit the number of parallel threads to 2 and the tests pass. Is this good to merge/release?

@sriv sriv merged commit 77f328c into getgauge:master Jan 30, 2024
7 checks passed
@sriv
Copy link
Member

sriv commented Jan 30, 2024

thanks @mpekurny !

@mpekurny
Copy link
Contributor Author

@sriv is the plan to release my changes with the changes in this PR? Any idea when it will be released?

1 similar comment
@mpekurny
Copy link
Contributor Author

@sriv is the plan to release my changes with the changes in this PR? Any idea when it will be released?

@sriv
Copy link
Member

sriv commented Jan 31, 2024

My apologies. I should have marked this as a release candidate and that would have triggered a release.

I will aim to make a release by this weekend, hope that is acceptable to you?

@mpekurny
Copy link
Contributor Author

Yes, that works. Thanks @sriv

@sriv
Copy link
Member

sriv commented Feb 5, 2024

gauge-dotnet 0.5.3 is now released, thanks @mpekurny

sriv pushed a commit that referenced this pull request Feb 6, 2024
* Add .NET 8 support

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

* Update the init command to create a newer csproj file and removed the matrix for different dotnet versions in the build.yml

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

* Limiting the number of nodes to use for the feature tests

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

---------

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>
sriv pushed a commit that referenced this pull request Feb 6, 2024
* Add .NET 8 support

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

* Update the init command to create a newer csproj file and removed the matrix for different dotnet versions in the build.yml

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

* Limiting the number of nodes to use for the feature tests

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

---------

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
sriv pushed a commit that referenced this pull request Feb 6, 2024
* Add .NET 8 support

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

* Update the init command to create a newer csproj file and removed the matrix for different dotnet versions in the build.yml

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

* Limiting the number of nodes to use for the feature tests

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

---------

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
sriv added a commit that referenced this pull request Feb 6, 2024
* check if method is async and await results, #199

Signed-off-by: sriv <srikanth.ddit@gmail.com>

* Add .NET 8 support (#200)

* Add .NET 8 support

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

* Update the init command to create a newer csproj file and removed the matrix for different dotnet versions in the build.yml

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

* Limiting the number of nodes to use for the feature tests

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

---------

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>

* add check to guard against async void impl

step implementations with async void are treated as not implemented

Signed-off-by: sriv <srikanth.ddit@gmail.com>

* bump version 0.6.0

Signed-off-by: sriv <srikanth.ddit@gmail.com>

* fix nunit assert syntax

Signed-off-by: sriv <srikanth.ddit@gmail.com>

* make MethodExecutor.Execute handle async, #199

the entire method execution chain is now async

Signed-off-by: sriv <srikanth.ddit@gmail.com>

* preserve arguments check when executing hook

Signed-off-by: sriv <srikanth.ddit@gmail.com>

---------

Signed-off-by: sriv <srikanth.ddit@gmail.com>
Signed-off-by: Martin Pekurny <mpekurny@paychex.com>
Co-authored-by: mpekurny <49953914+mpekurny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants