Check if parameter is number before Number.parse

[zabil]

Fixes #190 #187

[zabil]

@BugDiver not sure if this is the best way to fix it. Do take a look.

[anthony-legay]

I thought of using a regex but wanted to avoid it because it seemed overkill, but I'm afraid we don't have a choice.
I came up during my investigations with this regex: /^[+-]?(\d+(\.\d*)?|\.\d+)([eE][+-]?\d+)?$/ (thanks ChatGPT) to handle extreme case where users would use exponential notations (e.g. 2e-32). Seems unlikely, but...well better safe than sorry 😄

What if Gauge allowed the "special parameter" notation to specify a plain string like <string:0123456> and then it would bypass this? 🤔

[zabil]

What if Gauge allowed the "special parameter" notation to specify a plain string like string:0123456 and then it would bypass this?

Thanks for the suggestion! The idea of using a special parameter like <string:0123456> makes sense. However, it's best to keep Gauge specs as readable and close to markdown as possible. This is to have that clear separation and make the reports readable to people who are not that technical.

[zabil]

@anthony-legay pushed a simpler approach refer 910e614

Is there a way you can test this locally?

[gaugebot]

@zabil Thank you for contributing to gauge-ts. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

[chadlwilson]

Fixed the artifact upload/download. Otherwise LGTM

[zabil]

Fixed the artifact upload/download.

Thanks! @chadlwilson

[anthony-legay]

Sorry, I'm coming after the party, but this does not actually fix the issue when a value like "0123456" (such as a product id, or serial number) is used as a param and we want it to remains a string.
But this may be part of another bigger issue, what if some kind of serial number (e.g. not an EAN13 but even bigger) is used ? it does not make sens to convert this to a number, and it could even lead to overflow issues. 🫠
I don't know, not blaming anything here, thanks for the fix anyway ! I'm just throwing ideas and warnings about automatic number conversion 🙂

[zabil]

when a value like "0123456" (such as a product id, or serial number) is used as a param and we want it to remains a string.

Ah shoot.