Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject media #31

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

inject media #31

wants to merge 2 commits into from

Conversation

werty1st
Copy link

@werty1st werty1st commented Sep 8, 2022

hi,

i'm not a php or grav expert but i managed to modify the plugin so it can include files attached as page media.

i need this to include plotly.js plots directly without using iframes.

image

i don't know if the modifications broke something. but if you want to, you should easily be able to include this functionality to your plugin the right way.

kind regards

@rhukster
Copy link
Member

rhukster commented Sep 9, 2022

Interesting! It would be great if you could also include an updated README.md, and CHANGELOG.md with this PR.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants