Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirects & Routes broken in latest release #1420

Closed
immersegfx opened this issue Apr 11, 2017 · 2 comments
Closed

Redirects & Routes broken in latest release #1420

immersegfx opened this issue Apr 11, 2017 · 2 comments
Labels
bug

Comments

@immersegfx
Copy link

It appears that version 1.2.1 introduced a bug in \Grav\Common\Pages\Pages https://github.com/getgrav/grav/blob/develop/system/src/Grav/Common/Page/Pages.php#L399

$route = $config->get("site.routes.{$route}"); overrides the $route with null which is passed to the $source_url variable that can't be matched.
rhukster added a commit that referenced this issue Apr 11, 2017
@rhukster
Fix for redirects breaking #1420
60f97f2
@rhukster
Copy link
Member

Argghhh.. Good catch. This slipped through when i reviewed the PR. Can you please test my fix (linked above)

@rhukster rhukster added the bug label Apr 11, 2017
@immersegfx
Copy link
Author

Looks good to me, successfully tested on my site. thanks for the quick patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhukster @immersegfx