Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS/JS pipeline issues if URL contains query parameters #1451

Closed
mahagr opened this issue Apr 26, 2017 · 2 comments
Closed

CSS/JS pipeline issues if URL contains query parameters #1451

mahagr opened this issue Apr 26, 2017 · 2 comments

Comments

@mahagr
Copy link
Member

mahagr commented Apr 26, 2017

Fix looks something like this:

gantry/gantry5@627c070

@mahagr mahagr added the bug label Apr 26, 2017
@rhukster
Copy link
Member

Which URL is this? The URL of the asset? so:

{% do assets.addCss('theme://css-compiled/nucleus.css?for=bar') %}

???

@mahagr
Copy link
Member Author

mahagr commented Apr 28, 2017

Yeah, it removes ?foo=bar from assets that are local files. Without this the file cannot be found and is not added into the pipeline, causing it to be silently removed.

Though my fix does not deal with CSS/JS files, which are generated by a script. We may also want to ignore assets which cannot be found from the filesystem instead of just removing them in the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants