Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$_SERVER['HTTPS'] is not defined in some servers #1698

Closed
mahagr opened this issue Oct 17, 2017 · 3 comments
Closed

$_SERVER['HTTPS'] is not defined in some servers #1698

mahagr opened this issue Oct 17, 2017 · 3 comments
Assignees
@mahagr
Labels
bug

Comments

@mahagr
Copy link
Member

mahagr commented Oct 17, 2017 •
edited
Loading

See: a9c8271
@mahagr mahagr added the bug label Oct 17, 2017
@mahagr mahagr self-assigned this Oct 17, 2017
mahagr added a commit that referenced this issue Oct 17, 2017
@mahagr
Uri: Prefer using REQUEST_SCHEME instead of HTTPS (#1698)
3176158
@mahagr mahagr closed this as completed Oct 17, 2017
@mahagr
Copy link
Member Author

mahagr commented Oct 17, 2017

@paulmassen Created an issue for this. Please test out the fix.

@paulmassen
Copy link
Contributor

Thanks @mahagr . Can confirm it works 👍

This is probably an edge case, but cloud9 runs with https and on port 80, so port is still here on my cloud9 env, but I don't think it is worth fixing this just for people running it on cloud9.

@mahagr
Copy link
Member Author

mahagr commented Oct 17, 2017

it has to have port because of you're using non-standard one for https. :)

@mahagr mahagr mentioned this issue Nov 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahagr mahagr

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mahagr @paulmassen