Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with URL encoding in Cyrillic #1749

Closed
miketsts opened this issue Nov 16, 2017 · 3 comments
Closed

Problem with URL encoding in Cyrillic #1749

miketsts opened this issue Nov 16, 2017 · 3 comments
Labels

Comments

@miketsts
Copy link

I embed the following link in the markdown:
[George Orwell](https://ru.wikipedia.org/wiki/%D0%94%D0%B6%D0%BE%D1%80%D0%B4%D0%B6_%D0%9E%D1%80%D1%83%D1%8D%D0%BB%D0%BB)

As a result, I get the following link in the browser:
https://ru.wikipedia.org/wiki/%D0%94%D0%B6%D0%BE%D1%80%D0%B4%D0%B6_%D0%9E%D1%80%D1%83%EF%BF%BD_%D0%BB%D0%BB

Apparently, the UTF8 replacement symbol "%EF%BF%BD_" is inserted instead of "%D1%8D".
Another example with some other problematic characters:
[Aldous Huxley](https://ru.wikipedia.org/wiki/%D0%A5%D0%B0%D0%BA%D1%81%D0%BB%D0%B8,_%D0%9E%D0%BB%D0%B4%D0%BE%D1%81)

is converted to:
https://ru.wikipedia.org/wiki/%D0%A5%D0%B0%D0%BA%EF%BF%BD_%D0%BB%D0%B8,_%D0%9E%D0%BB%D0%B4%D0%BE%EF%BF%BD_

rhukster referenced this issue Nov 16, 2017
…pia)`)

Added stream support for links (`[Download PDF](user://data/pdf/my.pdf)`)
@rhukster
Copy link
Member

I found the issue, I just need to understand the implications of fixing it. :)

@rhukster
Copy link
Member

Ok this should work, and be 'safe' for other non-multibyte URLs

@miketsts
Copy link
Author

Works for me.
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants