Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1389 related to bin/gpm direct-install #1397

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Fix #1389 related to bin/gpm direct-install #1397

merged 1 commit into from
Apr 3, 2017

Conversation

gnufred
Copy link
Contributor

@gnufred gnufred commented Apr 1, 2017

Add --all-yes and --destination options

Fix a problem where temporary package files will not be
cleaned upon command error.

Add --all-yes and --destination options

Fix a problem where temporary package files will not be
cleaned upon command error.
@gnufred
Copy link
Contributor Author

gnufred commented Apr 1, 2017

@OleVik This PR is ready to review 🎉

@OleVik
Copy link
Contributor

OleVik commented Apr 1, 2017

Will check it out tomorrow evening.

@rhukster
Copy link
Member

rhukster commented Apr 1, 2017

Looks good from just looking at it. Will test it myself later.

BTW, could you also add your folder/file cleanup to the admin GPM command to keep things consistent? https://github.com/getgrav/grav-plugin-admin/blob/develop/classes/gpm.php#L203

@gnufred
Copy link
Contributor Author

gnufred commented Apr 1, 2017

@OleVik One more detail: I didn't add --force. I didn't find any cache hits. Check this comment for full details.

@gnufred
Copy link
Contributor Author

gnufred commented Apr 1, 2017

@OleVik
Copy link
Contributor

OleVik commented Apr 2, 2017

all-yes works well, but I did notice an oddity in temp-folder creation: One temp folder is created for the .zip-package, another for its extracted contents - presumably they belong in the same temporary cache. Though since both are removed in the process it's largely irrelevant. Had no infidelities on Windows either; all native functions for extracting and moving, and subsequently cleaning up, appear to be working as they should.

Looks good to me.

@gnufred
Copy link
Contributor Author

gnufred commented Apr 2, 2017

@OleVik It's the basic and intended behavior.

  • copy .zip in tmp/ and run some checks
  • extract and check
  • install
  • cleanup

@rhukster rhukster merged commit 459b7c4 into getgrav:develop Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants