Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Vikunja service widget #4118

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

Conversation

vhsdream
Copy link

Proposed change

Created a new service widget for the task management application Vikunja (feature request #1630).

Widget with default settings

image

Widget with enableTaskList option set to true

image

API calls output (2 API calls in total)

projects.json
tasks.json

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@vhsdream vhsdream marked this pull request as ready for review October 12, 2024 04:15
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick notes for now. I’ll find some time to test

src/widgets/vikunja/component.jsx Outdated Show resolved Hide resolved
src/utils/config/service-helpers.js Outdated Show resolved Hide resolved
src/widgets/vikunja/component.jsx Outdated Show resolved Hide resolved
@shamoon
Copy link
Collaborator

shamoon commented Oct 12, 2024

Thanks for the changes. Overall pretty good, just made some changes as you'll see. Let me know if you have any questions / concerns of course

@shamoon shamoon enabled auto-merge (squash) October 12, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants