Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openapi4filter: improve CSV resp decoder performance #948

Merged
merged 2 commits into from
May 11, 2024
Merged

openapi4filter: improve CSV resp decoder performance #948

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7d392d
Improve csv resp decoder performance
mpoqq May 6, 2024
e2603dd
Update req_resp_decoder.go
mpoqq May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions openapi3filter/req_resp_decoder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1562,7 +1562,7 @@ func zipFileBodyDecoder(body io.Reader, header http.Header, schema *openapi3.Sch
func csvBodyDecoder(body io.Reader, header http.Header, schema *openapi3.SchemaRef, encFn EncodingFn) (interface{}, error) {
r := csv.NewReader(body)

var content string
var sb strings.Builder
for {
record, err := r.Read()
if err == io.EOF {
Expand All @@ -1572,8 +1572,9 @@ func csvBodyDecoder(body io.Reader, header http.Header, schema *openapi3.SchemaR
return nil, err
}

content += strings.Join(record, ",") + "\n"
sb.WriteString(strings.Join(record, ","))
sb.WriteString("\n")
}

return content, nil
return sb.String(), nil
}
Loading