Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi3: internalize refs for path parameters #960

Merged

Conversation

selaux
Copy link
Contributor

@selaux selaux commented Jun 5, 2024

This is an attempt to close #959.

It adapts the code path for ops.Parameters to the same logic as the code path for op.Parameters (the path parameters), which already uses derefParameter to resolve external references in the operations parameters.

Tests as described in the bug ticket are included.

@fenollp fenollp changed the title Internalize refs for path parameters openapi3: internalize refs for path parameters Jun 10, 2024
Copy link
Collaborator

@fenollp fenollp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@fenollp fenollp merged commit 43846d5 into getkin:master Jun 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InternalizeRefs does not internalize parameters of paths
2 participants