chore(ci): tentative fix pronto #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienbourdeau
force-pushed
the
chore/pronto-error
branch
9 times, most recently
from
1040031
to
f7e7395
Compare
julienbourdeau
force-pushed
the
chore/pronto-error
branch
from
f7e7395
to
08feb24
Compare
vincent-pochet
approved these changes
Apr 9, 2024
drejc
pushed a commit
to fliqa-io/lago-api
that referenced
this pull request
May 15, 2024
Yesterday, all our `pronto` actions started [failing like this](https://github.com/getlago/lago-api/actions/runs/8600901566/job/23566843917?pr=1854). It turned out that there was a bug introduced in rubocop, which made it incompatible with `rubocop-rails`. A [fix](rubocop/rubocop#12826) seems on the way. rubocop/rubocop#12823 One way to mitigate this is to use `bundle exec rubocop` instead of global `rubocop`. We don't have pronto in our Gemfile so let's move to regular rubocop for now. Ideally, we'd like to move to checks like this: getlago#1856 Note: It's necessary to exit if there is no files to run because you can run rubocop on the entire codebase today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday, all our
prontoactions started failing like this.It turned out that there was a bug introduced in rubocop, which made it incompatible with
rubocop-rails. A fix seems on the way.rubocop/rubocop#12823
One way to mitigate this is to use
bundle exec rubocopinstead of globalrubocop. We don't have pronto in our Gemfile so let's move to regular rubocop for now.Ideally, we'd like to move to checks like this: #1856
Note: It's necessary to exit if there is no files to run because you can run rubocop on the entire codebase today.