feat(events): Refactor PayInAdvance Billable Metric validation #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunomiguelpinto
previously approved these changes
Jun 6, 2024
julienbourdeau
commented
Jun 7, 2024
julienbourdeau
force-pushed
the
fix/check-event-invoiceable-false
branch
from
0214542
to
fd979fc
Compare
julienbourdeau
changed the title
invoiceable: false charge too
julienbourdeau
force-pushed
the
fix/check-event-invoiceable-false
branch
2 times, most recently
from
5ec699e
to
ebeb611
Compare
julienbourdeau
force-pushed
the
fix/check-event-invoiceable-false
branch
from
ebeb611
to
24cca30
Compare
julienbourdeau
force-pushed
the
fix/check-event-invoiceable-false
branch
from
24cca30
to
9845c8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever a event associated with PayInAdvance charge is recieved, we create a Fee for this event.
The validation was performed only after we create the Fee for
invoiceable: falsecharges creating some disparities if the charge is invoiceable or not.I realized that there is already a validation on the aggregation in the Charge model, which I refactored.
I have removed all the validation in the PostProcess events because, you're not supposed to be able to create invalid charge (see Charge model validation) and if you send events without theIt creates a fee even without valid properties so I'm keeping the condition as-is, but earlier in the function.properties[bm.field_name], I'm not sure it should fail silently.