misc(migrations) - Add extra check to make sure schema.rb is up to date. #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
force-pushed
the
toon-devex-make-sure-schema.rb-uptodate
branch
4 times, most recently
from
c9885ef
to
dbedbd3
Compare
nudded
force-pushed
the
toon-devex-make-sure-schema.rb-uptodate
branch
from
dbedbd3
to
b0775bf
Compare
nudded
changed the title
julienbourdeau
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Interesting. My approach was to check git after the migration were executed.
https://github.com/getlago/lago-api/pull/2272/files
|
I love seeing the diff in the Github Action output 👌 |
I've tried this as well, but by default the schema.rb is not dumped when running the migrations. (And when debugging with |
nudded
force-pushed
the
toon-devex-make-sure-schema.rb-uptodate
branch
from
b0775bf
to
b2f63aa
Compare
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
…te. (getlago#2347) ## Description Make sure schema.rb is up to date with latest migrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure schema.rb is up to date with latest migrations.