Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable back cypress #1719

Merged
merged 10 commits into from
Sep 11, 2024
Merged

chore: enable back cypress #1719

merged 10 commits into from
Sep 11, 2024

Conversation

keellyp
Copy link
Collaborator

@keellyp keellyp commented Sep 5, 2024 •
edited
Loading

Context

This PR should enable back E2E tests with Cypress latest version.

Description

  • Valid tests
  • Enable CI
  • Enable screenshots and videos uploads for failing tests

Fixes ISSUE-397

@keellyp keellyp marked this pull request as ready for review September 5, 2024 16:20
@keellyp keellyp force-pushed the fix-e2e branch 14 times, most recently from f021563 to 4096ef9 Compare September 10, 2024 16:49
@keellyp keellyp self-assigned this Sep 10, 2024
ansmonjol
ansmonjol approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@ansmonjol ansmonjol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments, approved in the meantime so I don't block you!

@keellyp keellyp merged commit 1d7dbe0 into main Sep 11, 2024
6 checks passed
@keellyp keellyp deleted the fix-e2e branch September 11, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansmonjol ansmonjol ansmonjol approved these changes

@stephenlago99 stephenlago99 Awaiting requested review from stephenlago99

Assignees

@keellyp keellyp

Labels
🌈 improvement 🧪 testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keellyp @ansmonjol