Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Include Manga Name with Link on the "Continue Reading" cards #84

Closed
cglatot opened this issue Jul 1, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@cglatot
Copy link

cglatot commented Jul 1, 2020

Is your feature request related to a problem? Please describe.
Currently on the Home page, under Continue Reading, the cards only display the title of the chapter.

Describe the solution you'd like
I'd like to see the Manga name underneath the Chapter Name.

Describe a small use-case for this feature request
So you know what the manga actually is, as the chapter names and art are not always descriptive

@cglatot cglatot added the enhancement New feature or request label Jul 1, 2020
@hkalexling
Copy link
Member

Are you aware that after clicking on a chapter card, there's a link to the manga page in the pop-up modal? See #37 (comment)

@cglatot
Copy link
Author

cglatot commented Jul 2, 2020

Good point - completely forgot about that when writing the request. Updated the request to fix wording. I still think there is merit in having the Manga name underneath the chapter name so you can see at a glance which entry is which manga without having to click on it first.

@jaredlt
Copy link
Collaborator

jaredlt commented Jul 2, 2020

I tend to agree. In addition to the problem @cglatot points out (entry title may be ambiguous eg. Ch. 7) we should also consider that sometimes the cover image may be ambiguous too (eg. Some release groups put their 'advertising' page first which isn't always clear what it represents). If we can, we should assume the worst and design the interface to still be usable with all possible issues present.

I mocked the below up some time ago when toying with the original Home concept. It borrows heavily from Plex regarding the UX which I think they do well. This redesign is a bit more extreme in that it does more than just introduce the title. It removes the boxes, makes the font smaller and has it sit flush to the sides (so longer titles fit more characters). If we wanted something a little closer to the existing design, I've mocked up a quick version in the second image, below.

82124010-5da0e180-9794-11ea-94c4-ddf5f2c0e190

Second option, closer to existing design:

home-with-title
(I reduced the font-size to 1rem, all other css changes should be in the screenshot)

If we go with an approach like this I think it would make sense to show text-decoration: underline; on hover (for both title and entry text).

What do you think?

@cglatot
Copy link
Author

cglatot commented Jul 2, 2020

I like both designs - but agree to the smaller font. Having more room for the actual title / chapter name would be nice - even across all the other cards too.

@hkalexling
Copy link
Member

@jaredlt As always, love your designs! I think I will go with the second one (closer to the current design). I will work on this soon 👍

@hkalexling
Copy link
Member

Added in v0.7.3. Thanks to @cglatot for the feature requests and thank you @jaredlt for your UI design!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants