Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/plugin v2 #284

Merged
merged 42 commits into from
Mar 22, 2022
Merged

Feature/plugin v2 #284

merged 42 commits into from
Mar 22, 2022

Conversation

hkalexling
Copy link
Member

@hkalexling hkalexling commented Mar 16, 2022

A new version of the plugin system that supports the following additional features:

To target the new v2 API, plugins must put 2 in the api_version field in the info.json file. For backward compatability, any plugin without the api_version specified will be treated as a v1 plugin.

Closes #24. Related getmango/mango-plugins#10 and getmango/mango-plugins#7.

@Leeingnyo
Copy link
Member

It's a very impressive and fantastic feature! It seems you have done really hard work, Thank you.
I really liked the component pattern that applied to subscription-manager and plugin-download, it seems toward to a standalone client.
I have read most of codes (except plugin-download, api :p I just had a glance at them), and they looks good to me.

Here's some notices.

  1. After applying filters at plugin-download.html, sorted columns are not preserved though the UI is set to sorted.

스크린샷 2022-03-19 오전 2 01 06

First, get search result and sort them (I searched New Game! for example). the table shows well sorted columns started with 1.

스크린샷 2022-03-19 오전 2 05 25

After apply filter 'volume = 6' (min 6, max 6), the UI shows that the results are sorted by chapter though they are not actually.

This occurred too when I select another manga at the search result.


I would propose these, too.

  1. Show a confirm modal when deleting subscriptions
  2. In subscription detail modal, show a manga title at somewhere.

Thanks again for your hard work.

@hkalexling
Copy link
Member Author

@Leeingnyo Thanks for reviewing the PR! These are all good points that can help improve the user experience. I will update the PR.

@hkalexling hkalexling merged commit 461398d into dev Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MangaDex auto-updater?
2 participants