Separate third party libraries; resolves #79 #119
Conversation
| add_library(reflectcpp STATIC src/yyjson.c) | ||
| endif() | ||
| else() | ||
| if (REFLECTCPP_BUILD_SHARED) |
There was a problem hiding this comment.
Probably instead of SHARED or STATIC, INTERFACE would be the choice for Header-Only-Lib
https://cmake.org/cmake/help/latest/command/add_library.html#interface-libraries
|
|
||
| set_target_properties(reflectcpp PROPERTIES LINKER_LANGUAGE CXX) |
There was a problem hiding this comment.
Instead, probably could use the LANGUAGES section of project
https://cmake.org/cmake/help/latest/command/project.html
But setting it just to CXX, as this is a C++ project, gives trouble with the yyjson.c .
I guess it could be a C++ wrapper around it.
Maybe like
// yyjson.cpp
extern C {
#include "yyjson.c"
}Quick test shows, that at least clangd is happy with it, and uses the right compiler and flags.
| target_compile_features(reflectcpp PUBLIC cxx_std_20) | ||
|
|
||
| target_include_directories(reflectcpp PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> $<INSTALL_INTERFACE:include> ) | ||
| if(REFLECTCPP_USE_BUNDLED_DEPENDENCIES) | ||
| target_include_directories(reflectcpp PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> $<INSTALL_INTERFACE:include> $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include/rfl/thirdparty>) |
There was a problem hiding this comment.
If the thirdparty folder as set as extra include here, there should be no need to have the checks in the header files. I guess. Compiler should use the first header it finds, so if thirdparty is first, it should be okay.
No description provided.