Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.7 support, remove Python 3.3 support #1886

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

jonafato
Copy link
Contributor

As of #1733, Python 3.7 is supported, so reflect that in the Trove
classifiers.

As of 2017-09-29, Python 3.3 is end-of-life and no longer receives
updates of any kind (including security fixes), so remove it from the
list of supported versions.

@coveralls
Copy link

coveralls commented Oct 19, 2018

Coverage Status

Coverage remained the same at 92.584% when pulling 4c605ba on jonafato:python-versions into c2a1f4e on spulec:master.

@spulec
Copy link
Collaborator

spulec commented Dec 29, 2018

Hmmm, any idea why Travis is failing?

As of getmoto#1733, Python 3.7 is supported, so reflect that in the Trove
classifiers.

As of 2017-09-29, Python 3.3 is end-of-life and no longer receives
updates of any kind (including security fixes), so remove it from the
list of supported versions.
@jonafato
Copy link
Contributor Author

@spulec I mistakenly removed something required for 2.7 support. I've added that back in and rebased against master, so I expect everything to pass now.

@mikegrima
Copy link
Collaborator

@spulec Any issues merging this? We're using 3.7 internally with without moto issues.

@dargueta
Copy link
Contributor

While you're at it here, you could add python_requires to the setuptools.setup() call to make this package unavailable to unsupported Python versions. It won't even show up in pip search. I don't think the classifiers are obeyed by pip.

Unfortunately because you have to skip over 3.0-3.3, it's a little ugly:

setup(
    ...
    python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*'
)

@terricain
Copy link
Collaborator

I second adding python_requires,

@spulec spulec merged commit 1cbfa4a into getmoto:master Jul 8, 2019
@spulec
Copy link
Collaborator

spulec commented Jul 8, 2019

Thanks!

@jonafato jonafato deleted the python-versions branch July 8, 2019 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants