Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 - Fix exception for missing versionID #3887

Merged

Conversation

amarjandu
Copy link
Contributor

Fixes exception that is raised if a versionID is not found for calls to s3.

@codecov-commenter
Copy link

Codecov Report

Merging #3887 (985bf95) into master (f5e3cd8) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3887      +/-   ##
==========================================
- Coverage   94.86%   94.85%   -0.01%     
==========================================
  Files         447      447              
  Lines       48950    48966      +16     
==========================================
+ Hits        46438    46449      +11     
- Misses       2512     2517       +5     
Flag Coverage Δ
servertests 55.85% <50.00%> (-0.02%) ⬇️
unittests 94.72% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/s3/exceptions.py 93.64% <80.00%> (-2.81%) ⬇️
moto/s3/responses.py 96.39% <100.00%> (ø)
moto/logs/models.py 93.00% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e3cd8...985bf95. Read the comment docs.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the PR @amarjandu!

@bblommers bblommers merged commit 58381cc into getmoto:master Apr 30, 2021
@github-actions
Copy link
Contributor

This is now part of moto >= 2.0.6.dev14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants