S3: Adding notification for eventbridge #7252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7252 +/- ##
========================================
Coverage 95.88% 95.88%
========================================
Files 843 843
Lines 82578 82699 +121
========================================
+ Hits 79178 79299 +121
Misses 3400 3400
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
requested changes
Feb 15, 2024
There was a problem hiding this comment.
This looks really great @tsugumi-sys - just got a few minor comments.
| try: | ||
| from moto.events.models import events_backends | ||
|
|
||
| event = copy.deepcopy(_BASE_EVENT_MESSAGE) |
There was a problem hiding this comment.
The _BASE_EVENT_MESSAGE-import should also be local
moto/s3/notifications.py
Outdated
| "key": key.name, | ||
| "size": key.size, | ||
| "eTag": key.etag.replace('"', ""), | ||
| "version-id": "IYV3p45BT0ac8hjHg1houSdS1a.Mro8e", |
There was a problem hiding this comment.
Can we use key.version_id here?
bblommers
approved these changes
Feb 16, 2024
|
This is now part of moto >= 5.0.2.dev24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement S3 EventBridge notification.
put_objectnotification.Document of EventBridge event message structure: https://docs.aws.amazon.com/AmazonS3/latest/userguide/ev-events.html
Document of EventBridge notification: https://docs.aws.amazon.com/AmazonS3/latest/userguide/EventBridge.html