Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: add EventBridge notification for delete object tagging #7712

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions moto/s3/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -2687,8 +2687,17 @@ def delete_object_tagging(
self, bucket_name: str, key_name: str, version_id: Optional[str] = None
) -> None:
key = self.get_object(bucket_name, key_name, version_id=version_id)
bucket = self.get_bucket(bucket_name)

self.tagger.delete_all_tags_for_resource(key.arn) # type: ignore

notifications.send_event(
self.account_id,
notifications.S3NotificationEvent.OBJECT_TAGGING_DELETE_EVENT,
bucket,
key,
)

def delete_object(
self,
bucket_name: str,
Expand Down
35 changes: 35 additions & 0 deletions tests/test_s3/test_s3_eventbridge_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -305,3 +305,38 @@ def test_put_object_tagging_notification():
assert event_message["region"] == REGION_NAME
assert event_message["detail"]["bucket"]["name"] == bucket_name
assert event_message["detail"]["reason"] == "ObjectTagging"


@mock_aws
def test_delete_object_tagging_notification():
resource_names = _seteup_bucket_notification_eventbridge()
bucket_name = resource_names["bucket_name"]
s3_client = boto3.client("s3", region_name=REGION_NAME)

# Put Object
s3_client.put_object(Bucket=bucket_name, Key="keyname", Body="bodyofnewobject")

# Put Object Tagging
s3_client.put_object_tagging(
Bucket=bucket_name,
Key="keyname",
Tagging={
"TagSet": [
{"Key": "item1", "Value": "foo"},
{"Key": "item2", "Value": "bar"},
]
},
)

# Delete Object Tagging
s3_client.delete_object_tagging(Bucket=bucket_name, Key="keyname")

events = _get_send_events()
assert len(events) == 4
event_message = json.loads(events[3]["message"])
assert event_message["detail-type"] == "Object Tags Deleted"
assert event_message["source"] == "aws.s3"
assert event_message["account"] == ACCOUNT_ID
assert event_message["region"] == REGION_NAME
assert event_message["detail"]["bucket"]["name"] == bucket_name
assert event_message["detail"]["reason"] == "ObjectTagging"