Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS: service should have networkConfiguration #8318

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rafcio19
Copy link
Contributor

Resolves #8258

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.57%. Comparing base (10bdd08) to head (44ae6f1).

Files with missing lines Patch % Lines
moto/ecs/exceptions.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8318   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files        1159     1159           
  Lines      100936   100961   +25     
=======================================
+ Hits        95458    95482   +24     
- Misses       5478     5479    +1     
Flag Coverage Δ
servertests 28.89% <16.00%> (-0.01%) ⬇️
unittests 94.54% <96.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing networkConfiguration in create_service and describe_service of ECS Client
1 participant