implement CopyTags and Tags parameters for RDS copy_db_snapshot() #8320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing on AWS showed that tags are never merged. Instead, AWS uses either the provided Tags value or the tags of the original snapshot.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8320 +/- ##
=======================================
Coverage 94.57% 94.57%
=======================================
Files 1159 1159
Lines 100936 100936
=======================================
+ Hits 95458 95459 +1
+ Misses 5478 5477 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing on AWS showed that tags are never merged. Instead, AWS uses either the provided Tags value or the tags of the original snapshot.
Also, the old code always copied the tags of the source snapshots, but CopyTags actually defaults to False.
I'll apply the same change to copy_db_cluster_snapshot once this PR is merged. It behaves in the same way as copy_db_snapshot with regards to tags.