-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reference-stores): nuxt #70
Conversation
This pull request is being automatically deployed with Vercel (learn more). nacelle-js-nuxt-starter – ./starters/nuxt🔍 Inspect: https://vercel.com/nacelle/nacelle-js-nuxt-starter/8uyLdnjLr97j5QDyynKfKhQhorkX nacelle-js-gatsby-starter – ./starters/gatsby🔍 Inspect: https://vercel.com/nacelle/nacelle-js-gatsby-starter/Gkfzy1ppydomiWY2Sq4gs7rZaAFE [Deployment for 93302fb failed] |
Coverage report for
|
Status | Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 99.52% | 206/207 |
🟢 | Branches | 90.53% | 86/95 |
🟢 | Functions | 100% | 52/52 |
🟢 | Lines | 99.6% | 496/498 |
Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold
Report generated by 🧪jest coverage report action from 3ad13ae
'@nuxt/image', | ||
'@nuxtjs/svg', | ||
'@nuxtjs/pwa', | ||
'@nuxt/postcss8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a specific reason that we dropped @nuxt/tailwindcss
for a manual setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdarrik yea it seems like it has been abandoned. Nick was also seeing some error testing. The manual setup is what tailwind recommends for Nuxt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. The version of tailwind that @nuxtjs/tailwindcss
uses was conflicting with some of the tailwind plugins we're using.
For more context on the Nuxt module's state of neglect: nuxt-modules/tailwindcss#406.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I assume the line items stacking into one when adding to the cart is because of the empty variant id issue. I did have a small change on the cross sell items. As well as some potential updates on some search files, depending on what the goal of search is in our reference stores.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be working as expected:
- Landing page
- Collection PLP
- PDP
- Cart
- Cart cross-sells
- General pages
- Search
- Filtering
- Checkout
v2.Nuxt.Reference.Store.demo.LS-1451--nuxt-reference-store.mp4
Don't sweat the starters/gatsby
Vercel deploy preview failure - while the source of that issue is unclear, it appears to be an issue on main
that only presented today, for reasons unknown.
Thanks so much for the commitment and interaction on this PR!
WHY are these changes introduced?
Story [LS-1451] - Create a Nuxt.js Reference Store for Nacelle v2.
WHAT is this pull request doing?
reference-stores
How to Test
cd reference-stores/nuxt
.env
and add the followingnpm run dev
ornpm run build
andnpm run start
.Important Notes
@nuxt/image@0.5.0
is installed. The newer releases have a bug that causes dev server to crash when savingnuxt.config.js
file. Here is the issue:Receiving
Cannot read properties of undefined (reading 'get') on version 0.6.1
nuxt/image#481We will need a Vercel deployment for the nuxt reference store repo. Rather than create a new one, I think we should convert the old one. ** I do not have permission to update the git settings in Vercel.