Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Std::move #376

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Std::move #376

merged 2 commits into from
Sep 6, 2023

Conversation

getnamo
Copy link
Owner

@getnamo getnamo commented May 15, 2023

No description provided.

@Lootheo
Copy link
Contributor

Lootheo commented May 28, 2023

added a few missing std on #377

mikeseese
mikeseese approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@mikeseese mikeseese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good and fixes #375 in a handful of compilation environments, and the extra qualifying namespace should not break back-compatibility. This should be merged.

@getnamo getnamo merged commit 2156f78 into master Sep 6, 2023
@getnamo
Copy link
Owner Author

getnamo commented Sep 6, 2023

Thanks for confirming for me, merged.

@mikeseese mikeseese mentioned this pull request Oct 1, 2023
Closed
@getnamo getnamo deleted the Stdmove branch December 3, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeseese mikeseese mikeseese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@getnamo @Lootheo @mikeseese