Move to coverage to unit test

getodk · May 27, 2024 · 250aa91 · 250aa91
1 parent 8f6602c
commit 250aa91
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 19 deletions.
diff --git a/collect_app/src/androidTest/java/org/odk/collect/android/feature/formentry/EntityFormTest.kt b/collect_app/src/androidTest/java/org/odk/collect/android/feature/formentry/EntityFormTest.kt
@@ -108,25 +108,6 @@ class EntityFormTest {
             .assertTextDoesNotExist("Roman Roy")
     }
 
-    @Test
-    fun fillingEntityUpdateForm_withoutSelectingEntity_doesNothing() {
-        testDependencies.server.addForm(
-            "one-question-entity-update.xml",
-            listOf(EntityListItem("people.csv"))
-        )
-
-        rule.withMatchExactlyProject(testDependencies.server.url)
-            .setupEntities("people")
-
-            .startBlankForm("One Question Entity Update")
-            .swipeToNextQuestion("Name")
-            .swipeToEndScreen()
-            .clickFinalize()
-
-            .startBlankForm("One Question Entity Update")
-            .assertText("Roman Roy")
-    }
-
     @Test
     fun entityListSecondaryInstancesAreConsistentBetweenFollowUpForms() {
         testDependencies.server.apply {

diff --git a/entities/src/test/java/org/odk/collect/entities/LocalEntityUseCasesTest.kt b/entities/src/test/java/org/odk/collect/entities/LocalEntityUseCasesTest.kt
@@ -27,6 +27,17 @@ class LocalEntityUseCasesTest {
         assertThat(entitiesRepository.getEntities("things").size, equalTo(0))
     }
 
+    @Test
+    fun `updateLocalEntitiesFromForm does not save entity that doesn't have an ID`() {
+        val entity =
+            org.javarosa.entities.Entity(EntityAction.CREATE, "things", null, "1", 1, emptyList())
+        val formEntities = Entities(listOf(entity))
+        entitiesRepository.addList("things")
+
+        LocalEntityUseCases.updateLocalEntitiesFromForm(formEntities, entitiesRepository)
+        assertThat(entitiesRepository.getEntities("things").size, equalTo(0))
+    }
+
     @Test
     fun `updateLocalEntitiesFromServer overrides offline version if the online version is newer`() {
         entitiesRepository.save(Entity("songs", "noah", "Noa", 1))