Add retry click action

getodk · Apr 8, 2024 · 7c29ae5 · 7c29ae5
1 parent 2b52f12
commit 7c29ae5
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/collect_app/src/androidTest/java/org/odk/collect/android/support/pages/FormEndPage.java b/collect_app/src/androidTest/java/org/odk/collect/android/support/pages/FormEndPage.java
@@ -24,19 +24,15 @@ public FormEndPage assertOnPage() {
     }
 
     public <D extends Page<D>> D clickSaveAsDraft(D destination) {
-        return tryAgainOnFail(destination, () -> {
-            clickOnString(org.odk.collect.strings.R.string.save_as_draft);
-        });
+        return clickOnString(org.odk.collect.strings.R.string.save_as_draft, destination);
     }
 
     public MainMenuPage clickSaveAsDraft() {
         return clickSaveAsDraft(new MainMenuPage());
     }
 
     public <D extends Page<D>> D clickFinalize(D destination) {
-        return tryAgainOnFail(destination, () -> {
-            clickOnString(org.odk.collect.strings.R.string.finalize);
-        });
+        return clickOnString(org.odk.collect.strings.R.string.finalize, destination);
     }
 
     public MainMenuPage clickFinalize() {

diff --git a/collect_app/src/androidTest/java/org/odk/collect/android/support/pages/FormEntryPage.java b/collect_app/src/androidTest/java/org/odk/collect/android/support/pages/FormEntryPage.java
@@ -251,7 +251,7 @@ public FormEntryPage longPressOnQuestion(String question) {
     }
 
     public FormEntryPage longPressOnQuestion(String question, boolean isRequired) {
-        return tryAgainOnFail(this, () -> {
+        WaitFor.tryAgainOnFail(() -> {
             if (isRequired) {
                 onView(withText("* " + question)).perform(longClick());
             } else {
@@ -260,6 +260,8 @@ public FormEntryPage longPressOnQuestion(String question, boolean isRequired) {
 
             assertText(org.odk.collect.strings.R.string.clear_answer);
         });
+
+        return this;
     }
 
     public FormEntryPage removeResponse() {

diff --git a/collect_app/src/androidTest/java/org/odk/collect/android/support/pages/Page.kt b/collect_app/src/androidTest/java/org/odk/collect/android/support/pages/Page.kt
@@ -238,6 +238,15 @@ abstract class Page<T : Page<T>> {
         return checkIsToastWithMessageDisplayed(getTranslatedString(id, *formatArgs))
     }
 
+    fun <D : Page<D>> clickOnString(stringID: Int, destination: D): D {
+        tryAgainOnFail {
+            clickOnString(stringID)
+            destination.assertOnPage()
+        }
+
+        return destination
+    }
+
     fun clickOnString(stringID: Int): T {
         clickOnText(getTranslatedString(stringID))
         return this as T