-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved text sizing in main menu #5568
Improved text sizing in main menu #5568
Conversation
@alyblenkin @grzesiek2010 how would you feel about adding our own custom text token for this? It definitely doesn't feel like we want to bump "Label large" to 18sp as this would cause problems for smaller buttons. I do imagine we'll end up using a similar style for buttons in widgets (also full width and a place we want an easy tap target vertically). I'd usually not like the idea of "extending" Material, but I personally feel OK introducing a "label extra large" ( |
@seadowg @grzesiek2010, I think adding our own custom text token makes a lot of sense because it seems like there is a gap between their typography library. And I agree that we would be using it in other similar scenarios. I also added a story for unifying all the buttons . I still need to flesh it out more, but I think we could do them separately. Let me know what you think. |
Can I test this on my device before I add my review? |
I'll send you a build. I've got a todo to have them generated for you, but haven't had a chance to take care of that yet. |
5f4026e
to
cfa1297
Compare
cfa1297
to
cd6f28c
Compare
@alyblenkin let us know if you're happy with the changes, and we can go ahead and merge. I don't think we need QA on this one. |
Looks great! |
What has been done to verify that this works as intended?
I've tested the fix and compared it with how it looks on master.
Why is this the best possible solution? Were any other approaches considered?
This is what we have discussed with @alyblenkin
textAppearanceLabelLarge
is the recommended style for this type of button according to https://github.com/material-components/material-components-android/blob/master/docs/components/Button.md#text-label-attributes and18sp
makes it a little bit smaller.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.