Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max width for form end view for wider screens #5585

Merged
merged 1 commit into from
May 15, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions collect_app/src/main/res/layout/form_entry_end.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,22 +31,23 @@ the specific language governing permissions and limitations under the License.
android:textSize="21sp"
android:textStyle="bold"
app:layout_constraintBottom_toTopOf="@+id/form_edits_warning"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintStart_toStartOf="@id/form_edits_warning"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintVertical_chainStyle="packed"
tools:text="You are at the end of All widgets" />

<com.google.android.material.card.MaterialCardView
android:id="@+id/form_edits_warning"
style="@style/Widget.Material3.CardView.Filled"
android:layout_width="match_parent"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/margin_large"
app:cardBackgroundColor="?colorSurfaceContainerHighest"
app:layout_constraintBottom_toTopOf="@+id/save_as_draft"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@+id/description"
app:layout_constraintBottom_toTopOf="@+id/save_as_draft"
app:layout_constraintWidth_max="640dp"
tools:visibility="visible">

<androidx.constraintlayout.widget.ConstraintLayout
Expand Down Expand Up @@ -80,12 +81,12 @@ the specific language governing permissions and limitations under the License.
style="@style/Widget.Material3.Button.OutlinedButton"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/margin_extra_large"
android:layout_marginTop="64dp"
android:layout_marginEnd="@dimen/margin_small"
android:text="@string/save_as_draft"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@+id/finalize"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintStart_toStartOf="@id/form_edits_warning"
app:layout_constraintTop_toBottomOf="@+id/form_edits_warning" />

<com.google.android.material.button.MaterialButton
Expand All @@ -96,8 +97,8 @@ the specific language governing permissions and limitations under the License.
android:layout_marginStart="@dimen/margin_small"
android:text="@string/finalize"
app:layout_constraintBottom_toBottomOf="@id/save_as_draft"
app:layout_constraintEnd_toEndOf="@id/form_edits_warning"
app:layout_constraintStart_toEndOf="@id/save_as_draft"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="@id/save_as_draft" />

</androidx.constraintlayout.widget.ConstraintLayout>
Expand Down