Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations #5664

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

lognaturel
Copy link
Member

Indonesian and Urdu users have said they are inconvenienced by not having main menu translations so we are planning to do a patch release asap with those updated translations. This PR targets the v2023.2.x branch which will be used to release patches.

What has been done to verify that this works as intended?

Only visual inspection. I made sure not to revert sv-rSE which is used in connected tests.

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Do we need any specific form for testing your changes? If so, please attach one.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@lognaturel lognaturel marked this pull request as ready for review July 10, 2023 04:55
@lognaturel lognaturel merged commit 8be1655 into getodk:v2023.2.x Jul 10, 2023
@lognaturel lognaturel deleted the update-translations branch July 10, 2023 05:27
@lognaturel lognaturel restored the update-translations branch July 10, 2023 05:27
@lognaturel lognaturel deleted the update-translations branch July 27, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant