Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss snackbar before creating a new one #5682

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Jul 18, 2023

Closes #5662

What has been done to verify that this works as intended?

I've reviewed implemented changes.

Why is this the best possible solution? Were any other approaches considered?

As discussed in the issue it seems to be an Android bug and hopefully, this change will help us.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It doesn't require testing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

}.show()
}.addCallback(object : BaseTransientBottomBar.BaseCallback<Snackbar>() {
override fun onDismissed(transientBottomBar: Snackbar?, event: Int) {
super.onDismissed(transientBottomBar, event)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have already done this, but I think there's a couple of situations that we should double check that this gets called in:

  1. When the Snackbar is dismissed after being on screen for its duration
  2. When the Snackbar is dismissed manually
  3. When the Activity is destroyed before the Snackbar is dismissed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked those cases and it seems to work well.

@grzesiek2010 grzesiek2010 marked this pull request as ready for review July 18, 2023 11:07
@grzesiek2010 grzesiek2010 requested a review from seadowg July 18, 2023 11:34
@grzesiek2010 grzesiek2010 merged commit 2d544e1 into getodk:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FillBlankFormTest#app_ShouldNotCrash is flakey
2 participants