Fixed text alignment for RTL selects

[grzesiek2010]

Closes #5684

What has been done to verify that this works as intended?

I've tested the fix manually.

Why is this the best possible solution? Were any other approaches considered?

There is nothin to discuss here.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Please test the fix on many different Android versions. It's important to check those older - Android 5.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[grzesiek2010]

It looks like we no longer need to do that programmatically.

[dbemke]

In All widgets in selects with RTL applied radio buttons are to the right but choices are too the left.
Verified on the CI built app on Android 10,13. On the master version the issue doesn't occur.

[srujner]

I've also got few screens to compare behaviors on Android 5.1 and 13

Android 5.1 at the top, 13 at the bottom

[grzesiek2010]

I think this is the right behavior and forcing text that comes from an LTR language like English to be displayed on the right was wrong.
See the last point

from https://m2.material.io/design/usability/bidirectionality.html#mirroring-layout

@seadowg do you agree?

[seadowg]

Not sure I understand the problem here. Either way, I reckon this would be better to discuss with @alyblenkin.

[grzesiek2010]

Not sure I understand the problem here.

We used to force text that is from LTR languages to be displayed on the right side if the layout is RTL and the other way around. To me, this approach was wrong and also caused issues like #5684

[alyblenkin]

Hey @grzesiek2010, sorry for the slow response on this one! I agree that it was wrong to display LTR language on the right with RTL layouts. So we should always default to the language direction:

LTR language + RTL layout = displayed on the left
RTL language + LTR layout = displayed on the right

[grzesiek2010]

Thanks @alyblenkin so I'm adding the needs testing label back.

[srujner]

@grzesiek2010 And what about differences between Android 5.1 and 13 (at the screenshots above)? Which one is the correct behavior?

[grzesiek2010]

13 is the correct one and that is what you should see on most of the Android versions. If there is something wrong with the oldest versions Android 5 or 5 and 6 that's acceptable I would say.

[dbemke]

Selects with columns, texts and images look like that with RTL in Collect settings and All widgets form - is it ok? Users might find this case confusing - which picture is in A or B answer.

[grzesiek2010]

To me, it's a correct behavior. It's in RTL so elements are displayed from right to left but the labels come from an LTR language so they are on the left (in their containers). I would say that using LTR labels with RTL layout doesn't make sense so that's why it's confusing. I hope our users won't do that.

[dbemke]

Tested with Success!

Verified on device with Android 10

Verified cases:

• settings in the form from the issue Bad text alignment for RTL selects #5684 work as expected
• RTL, LTR set in the device and in Collect
• RTL, LTR settings in a form with selects

[srujner]

Tested with Success!

Verified on device with Android 5.1 and 13

[alyblenkin]

It's a good point @dbemke, this would be very confusing for users. I think having a two-column grid on mobile also adds to the confusion here. Ideally, we stick to one column, so it's very clear what to select - I've added this to my notes as something to explore.